Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address golint errors #159

Merged
merged 4 commits into from
Dec 13, 2024
Merged

Conversation

efiacor
Copy link
Collaborator

@efiacor efiacor commented Dec 12, 2024

Fixing golint issues

@efiacor
Copy link
Collaborator Author

efiacor commented Dec 12, 2024

/test presubmit-nephio-go-test

Copy link
Member

@liamfallon liamfallon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this Fiachra.

/approve

Copy link
Contributor

nephio-prow bot commented Dec 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: efiacor, liamfallon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Address review suggestion
@kispaljr
Copy link
Collaborator

lgtm

@efiacor
Copy link
Collaborator Author

efiacor commented Dec 13, 2024

lgtm

Missed the "/" :)

@liamfallon
Copy link
Member

/lgtm

@nephio-prow nephio-prow bot added the lgtm label Dec 13, 2024
@kispaljr kispaljr merged commit 102bc1b into nephio-project:main Dec 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants